So when we implemented the code we got something like this<\/p>\n
\r\n#Mr Stratton\r\n\r\nimport random\r\n\r\n#set up variables\r\nrandom.seed\r\nobject=["Rock","Paper","Scissors"]\r\nplayerChoice=""\r\ncomputerChoice=""\r\nwinner=""\r\n\r\n#Get players choice\r\nplayerChoice=object[int(input("Rock - 1\\nPaper - 2\\nScissors - 3\\n"))-1]\r\n\r\n#Get computer choice\r\ncomputerChoice=object[random.randint(0,2)]\r\n\r\n#get winner\r\nif playerChoice=="Rock":\r\n if computerChoice=="Paper":\r\n winner="Computer"\r\n if computerChoice=="Scissors":\r\n winner="Player"\r\n if computerChoice==playerChoice:\r\n winner="Draw"\r\n \r\nif playerChoice=="Paper":\r\n if computerChoice=="Scissors":\r\n winner="Computer"\r\n if computerChoice=="Rock":\r\n winner="Player"\r\n if computerChoice==playerChoice:\r\n winner="Draw"\r\n \r\nif playerChoice=="Scissors":\r\n if computerChoice=="Rock":\r\n winner="Computer"\r\n if computerChoice=="Paper":\r\n winner="Player"\r\n if computerChoice==playerChoice:\r\n winner="Draw"\r\n \r\n\r\n \r\n#display winner\r\nprint("\\n"*10)\r\nprint("Player threw",playerChoice)\r\nprint("Computer threw",computerChoice)\r\n\r\nif winner=="Player":\r\n print("Player is the winner")\r\n \r\nif winner=="Computer":\r\n print("Computer is the winner")\r\n \r\nif winner=="Draw":\r\n print("Its a draw")\r\n\r\n\r\n<\/pre>\nHowever, although it does follow the design from yesterday it isn’t very effcient.
\nCan you see a way to make it more effient?<\/p>\n
\r\n#Mr Stratton\r\n\r\nimport random\r\n\r\n#set up variables\r\nobject=["Rock","Paper","Scissors"]\r\nplayerChoice=""\r\ncomputerChoice=""\r\nwinner="Draw"\r\n\r\n#Get players choice\r\nplayerChoice=object[int(input("Rock - 1\\nPaper - 2\\nScissors - 3\\n"))-1]\r\n\r\n#Get computer choice\r\ncomputerChoice=object[random.randint(0,2)]\r\n\r\n#get winner\r\nif playerChoice=="Rock":\r\n if computerChoice=="Paper":\r\n winner="Computer"\r\n elif computerChoice=="Scissors":\r\n winner="Player"\r\n\r\n \r\nelif playerChoice=="Paper":\r\n if computerChoice=="Scissors":\r\n winner="Computer"\r\n elif computerChoice=="Rock":\r\n winner="Player"\r\n\r\n \r\nelif playerChoice=="Scissors":\r\n if computerChoice=="Rock":\r\n winner="Computer"\r\n elif computerChoice=="Paper":\r\n winner="Player"\r\n\r\n \r\nelse:\r\n print("Error in player choice")\r\n \r\n#display winner\r\nprint("\\n"*10)\r\nprint("Player threw",playerChoice)\r\nprint("Computer threw",computerChoice)\r\nif winner=="Player":\r\n print("Player is the winner")\r\nelif winner=="Computer":\r\n print("Computer is the winner")\r\nelse:\r\n print("Its a draw")\r\n\r\n<\/pre>\n<\/p>\n
That’s right use nested IFs and ELIF to reduce the number of IFs that need to be evaluated.
\nI have also made the code more effient (reduced the number of lines of code) in another way in the example above. Can you spot where?<\/p>\n
\r\n# I changed line 9 to assume it was always a draw which allowed me to remove \r\n# 6 lines of code that delt with this.\r\n# It is more effient but is it good programming practice?\r\n<\/pre>\n","protected":false},"excerpt":{"rendered":"So when we implemented the code we got something like this #Mr Stratton import random #set up variables random.seed object=["Rock","Paper","Scissors"] playerChoice="" computerChoice="" winner="" #Get players choice playerChoice=object[int(input("Rock – 1\\nPaper – 2\\nScissors – 3\\n"))-1] #Get computer choice computerChoice=object[random.randint(0,2)] #get winner if playerChoice=="Rock": if computerChoice=="Paper": winner="Computer" if computerChoice=="Scissors": winner="Player" if computerChoice==playerChoice: winner="Draw" if playerChoice=="Paper": if computerChoice=="Scissors": winner="Computer" …<\/p>\n","protected":false},"author":32,"featured_media":1386,"comment_status":"closed","ping_status":"closed","sticky":false,"template":"","format":"standard","meta":{"footnotes":""},"categories":[432098,17932,17009],"tags":[432099,125715,13697,33634],"class_list":["post-2018","post","type-post","status-publish","format-standard","has-post-thumbnail","hentry","category-higher","category-computational-constructs","category-software-design-devlopment","tag-elif","tag-python","tag-random","tag-selection"],"jetpack_featured_media_url":"https:\/\/blogs.glowscotland.org.uk\/nl\/public\/ColtnessHS-ComputingScience\/uploads\/sites\/12638\/2016\/09\/Slide4.png","jetpack_sharing_enabled":true,"_links":{"self":[{"href":"https:\/\/blogs.glowscotland.org.uk\/nl\/ColtnessHS-ComputingScience\/wp-json\/wp\/v2\/posts\/2018","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/blogs.glowscotland.org.uk\/nl\/ColtnessHS-ComputingScience\/wp-json\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/blogs.glowscotland.org.uk\/nl\/ColtnessHS-ComputingScience\/wp-json\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/blogs.glowscotland.org.uk\/nl\/ColtnessHS-ComputingScience\/wp-json\/wp\/v2\/users\/32"}],"replies":[{"embeddable":true,"href":"https:\/\/blogs.glowscotland.org.uk\/nl\/ColtnessHS-ComputingScience\/wp-json\/wp\/v2\/comments?post=2018"}],"version-history":[{"count":8,"href":"https:\/\/blogs.glowscotland.org.uk\/nl\/ColtnessHS-ComputingScience\/wp-json\/wp\/v2\/posts\/2018\/revisions"}],"predecessor-version":[{"id":2026,"href":"https:\/\/blogs.glowscotland.org.uk\/nl\/ColtnessHS-ComputingScience\/wp-json\/wp\/v2\/posts\/2018\/revisions\/2026"}],"wp:featuredmedia":[{"embeddable":true,"href":"https:\/\/blogs.glowscotland.org.uk\/nl\/ColtnessHS-ComputingScience\/wp-json\/wp\/v2\/media\/1386"}],"wp:attachment":[{"href":"https:\/\/blogs.glowscotland.org.uk\/nl\/ColtnessHS-ComputingScience\/wp-json\/wp\/v2\/media?parent=2018"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/blogs.glowscotland.org.uk\/nl\/ColtnessHS-ComputingScience\/wp-json\/wp\/v2\/categories?post=2018"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/blogs.glowscotland.org.uk\/nl\/ColtnessHS-ComputingScience\/wp-json\/wp\/v2\/tags?post=2018"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}